Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ch3 for BASHER #143

Merged
merged 2 commits into from Jun 30, 2023
Merged

Update ch3 for BASHER #143

merged 2 commits into from Jun 30, 2023

Conversation

derisen
Copy link
Contributor

@derisen derisen commented Jun 30, 2023

Pull Request

Purpose

  • ...

Does this introduce a breaking change

    [ ] Yes
    [ ] No

Pull request type

What kind of change does this Pull Request introduce?

    [ ] Bugfix
    [ ] Feature
    [ ] Code style update (formatting, local variables)
    [ ] Documentation content changes
    [ ] Other... Please describe:

How to test

  • Get the code
    git clone [repo-address]
    cd [repo-name]
    git checkout [branch-name]
    npm install
  • Test the code

What to check

ex: verify that the following are valid:

  • ...

Other Information

3-Authorization-II/1-call-api/SPA/server.js Dismissed Show dismissed Hide dismissed
@derisen derisen merged commit a272cac into main Jun 30, 2023
3 checks passed
@derisen derisen deleted the basher-ch-3 branch June 30, 2023 22:52
Comment on lines +17 to +19
app.get('/redirect', (req, res) => {
res.sendFile(path.join(__dirname + '/public/redirect.html'));
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
, but is not rate-limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant