Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid slugs #5

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

v-xuto
Copy link

@v-xuto v-xuto commented Feb 1, 2024

According to doc, remove invalid slugs azure-application-insights, css, scss.

@hemarina, @wangmingliang-ms for notification.

products:
- azure
- azure-application-insights
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check application-insights slug?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemarina The product section in this doc does not contain application-insights slug. Besides, azure-monitor has been added under the products in this readme, and the application-insights slug is the ms.subservice slug of azure-monitor. So, I feel that leaving azure-monitor should be enough. What do you think?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged.

@wangmingliang-ms wangmingliang-ms merged commit ec32fb0 into Azure-Samples:main Feb 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants