New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jchomarat/purview terraform recipe #28
Jchomarat/purview terraform recipe #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR and recipe! Please review the feedback. Happy to continue the dialogue!!
Should probably update docs/Recipes.md to indicate the addition of the Terraform recipe. |
…on-recipes into jchomarat/purview-terraform-recipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
@jchomarat, I will test it over the weekend and get back to you. |
LGTM. Waiting on review & feedback from @promisinganuj. |
@promisinganuj Any feedback on this? |
Reviewing it today :-) |
Just deployed, lgtm! We can update the terraform base version though (currently it's 1.3.2 which is quite old). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Purpose
This PR proposes the recipe to deploy Microsoft Purview behind a VNet in Terraform.
The code in this PR has been continued from previous work made by @meghdivya and @manjitsin.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
git clone [repo-address] cd [repo-name] git checkout [branch-name] npm install
Follow the documentation
What to Check
Verify that the following are valid
Other Information
This PR does not contain the CD pipelines as some re-work will be done on it