Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jchomarat/purview terraform recipe #28

Merged

Conversation

jchomarat
Copy link
Contributor

@jchomarat jchomarat commented Feb 6, 2023

Purpose

This PR proposes the recipe to deploy Microsoft Purview behind a VNet in Terraform.

The code in this PR has been continued from previous work made by @meghdivya and @manjitsin.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

Follow the documentation

cd src/az-purview/deploy/terraform
cp terraform.tfvars.sample terraform.tfvars
# Optionally: change variables values
az login # On your tenant/sub
terraform init
terraform plan -var-file=terraform.tfvars
# If good, then apply
terraform apply -var-file=terraform.tfvars

What to Check

Verify that the following are valid

  • A RG is created with Purview, a KeyVault and a storage account
  • All resources do not have public access
  • All resources expose private endpoint, registered in the VNet deployed

Other Information

This PR does not contain the CD pipelines as some re-work will be done on it

@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat had a problem deploying to virtual-network-integration-recipes February 6, 2023 08:26 — with GitHub Actions Failure
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 08:42 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 08:42 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 08:42 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 08:42 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 08:42 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 08:42 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 10, 2023 09:08 — with GitHub Actions Inactive
@jchomarat jchomarat marked this pull request as ready for review February 10, 2023 09:11
Copy link
Contributor

@mcollier mcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR and recipe! Please review the feedback. Happy to continue the dialogue!!

.gitignore Outdated Show resolved Hide resolved
.github/workflows/purview-recipe-ci.yml Outdated Show resolved Hide resolved
.github/workflows/purview-recipe-ci.yml Outdated Show resolved Hide resolved
.github/workflows/purview-recipe-ci.yml Outdated Show resolved Hide resolved
.github/workflows/purview-recipe-ci.yml Outdated Show resolved Hide resolved
@mcollier
Copy link
Contributor

Should probably update docs/Recipes.md to indicate the addition of the Terraform recipe.

@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 22, 2023 10:32 — with GitHub Actions Inactive
Copy link
Contributor

@mcollier mcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 24, 2023 07:54 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 24, 2023 07:54 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 24, 2023 07:54 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 24, 2023 07:54 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 24, 2023 07:54 — with GitHub Actions Inactive
@jchomarat jchomarat temporarily deployed to virtual-network-integration-recipes February 24, 2023 07:54 — with GitHub Actions Inactive
@promisinganuj
Copy link
Contributor

@jchomarat, I will test it over the weekend and get back to you.

@mcollier
Copy link
Contributor

mcollier commented Mar 3, 2023

LGTM. Waiting on review & feedback from @promisinganuj.

@mcollier
Copy link
Contributor

@promisinganuj Any feedback on this?

@promisinganuj
Copy link
Contributor

Reviewing it today :-)

@promisinganuj
Copy link
Contributor

Just deployed, lgtm! We can update the terraform base version though (currently it's 1.3.2 which is quite old).

Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@promisinganuj promisinganuj merged commit d9c2ae8 into Azure-Samples:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants