Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storage file share app settings; Resolve Bicep lint warnings. #36

Merged
merged 1 commit into from
May 3, 2023

Conversation

mcollier
Copy link
Contributor

Purpose

  • The WEBSITE_CONTENTAZUREFILECONNECTIONSTRING, WEBSITE_CONTENTSHARE, WEBSITE_CONTENTOVERVNET, and WEBSITE_SKIP_CONTENTSHARE_VALIDATION application settings should be used on Linux and Windows Elastic Premium plans, per App settings reference for Azure Functions
  • Resolves two Bicep linting warnings.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Open Visual Studio Code using the provided dev container definition.
  • Navigate to the ./src/az-func-http/deploy/bicep directory.
  • Save the azuredeploy.parameters.sample.json file as azuredeploy.parameters.json.
  • Review and edit the parameters in the azuredeploy.parameters.json file.
  • Edit the deploy.sh file to use the desired resource group (to be created by the script).
  • Make the deploy.sh file executable by running the chmod u+x deploy.sh command.
  • Execute the deploy.sh file.

What to Check

Verify that the following are valid:

  • The Bicep file should provision all resources without error.

Other Information

Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcollier mcollier merged commit a827a02 into main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants