Extra Deploy Helper release testing #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 29, 2022 12:37
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
mosabami
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #338
There was a Deploy Helper release edge case, whereby you could do a "UI Release only" if what you were releasing didn't have any breaking changes between the latest release and what was in main.
Unfortunately, we got bitten by this by a UI release between 0.8.7 and 0.8.8
This PR adds a new testing step which prevents a release of the UI beyond canary if the test suites don't pass.
PR Details
Predominantly this PR is just a simple refactor of testing code we already had into a reusable workflow. The new reusable workflow is called from the workflow file it was taken from but now also from the Release workflow.
PR Checklist