Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKS Keda AddOn #346

Merged
merged 3 commits into from
Aug 9, 2022
Merged

AKS Keda AddOn #346

merged 3 commits into from
Aug 9, 2022

Conversation

liammoat
Copy link
Contributor

@liammoat liammoat commented Aug 9, 2022 •
edited by Gordonby
Loading

PR Summary

This PR introduces the option to enable the AKS Keda Addon. Note: This feature is currently in preview.

resolves #294

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@liammoat liammoat requested a review from Gordonby August 9, 2022 09:21
@liammoat liammoat temporarily deployed to azurecirgs August 9, 2022 09:21 Inactive
@Gordonby Gordonby added the test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge label Aug 9, 2022
@Gordonby Gordonby changed the title add aks keda addon AKS Keda AddOn Aug 9, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs August 9, 2022 09:30 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs August 9, 2022 09:30 Inactive
@Gordonby Gordonby added enhancement New feature or request azure-preview-feature References a preview feature labels Aug 9, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs August 9, 2022 09:36 Inactive
@Gordonby
Copy link
Collaborator

Gordonby commented Aug 9, 2022 •
edited
Loading

Hey @liammoat

Looks like you need to add the word "KEDA" to the cspell.json file. VSCode can do tihs for you in the UI if you install the Cspell extension. (The spelling check is failing).

I've also added the test-deploy-byoconfig label to the PR, which FYI will complete a full deployment test.... So we can make sure that adding the new bicep changes won't break an existing known good config. You can see this run here :https://github.com/Azure/AKS-Construction/runs/7743169070?check_suite_focus=true

@liammoat liammoat temporarily deployed to azurecirgs August 9, 2022 10:16 Inactive
@liammoat liammoat temporarily deployed to azurecirgs August 9, 2022 10:19 Inactive
@Gordonby
Copy link
Collaborator

Gordonby commented Aug 9, 2022

LGTM. We might want to get more familiar with this before we do the next release.... but all the tests pass 🆗

@Gordonby Gordonby merged commit 9fe2731 into main Aug 9, 2022
@Gordonby Gordonby deleted the lm-keda branch August 9, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gordonby Gordonby Gordonby approved these changes

Assignees
No one assigned
Labels
azure-preview-feature References a preview feature enhancement New feature or request helper-ui test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Managed Keda
2 participants
@liammoat @Gordonby