-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for ETCD encryption with KMS #351
Conversation
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
… gb-kmsetcd Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month. |
@khowling - Thinking of de-scoping the private link scenario here. We could leverage a pattern of creating it public, and inserting the key then updating to be private, but this would be opaque and quite frankly a bit janky. Options
Thoughts? |
… gb-kmsetcd Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@khowling - it's ready! |
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
…into gb-kmsetcd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a good'n
PR Summary
Closes #303
TODO
- [ ] Create KMS Sample document that explains the bicep, that we can reference from the Azure Docs(Lets pick up in a different PR thats more docs focussed)UI
PR Checklist