Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ETCD encryption with KMS #351

Merged
merged 36 commits into from
Sep 21, 2022
Merged

Adding support for ETCD encryption with KMS #351

merged 36 commits into from
Sep 21, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Aug 12, 2022

PR Summary

Closes #303

TODO

  • Get working for public kv scenario
  • Add UI for KMS
  • Remove debug outputs from bicep
  • Delete KVPolicybased.bicep
    - [ ] Create KMS Sample document that explains the bicep, that we can reference from the Azure Docs (Lets pick up in a different PR thats more docs focussed)
  • Make sure it's not using the preview banner.
  • Show a warning message if privatelinks is enabled
  • Add an information message directing people to CSI KeyVault as a good alternative solution
  • Add byo capability
  • Test UI combinatons, evaulate if new messages needed
  • Test bicep byo kms

UI

image

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

Gordonby added 6 commits July 20, 2022 20:30
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
kms
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
… gb-kmsetcd

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs August 12, 2022 06:42 Inactive
@Gordonby Gordonby added the enhancement New feature or request label Aug 12, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs August 12, 2022 16:52 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs August 12, 2022 16:52 Inactive
@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Sep 12, 2022
@Gordonby Gordonby added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Sep 12, 2022
@Gordonby
Copy link
Collaborator Author

Gordonby commented Sep 13, 2022

@khowling - Thinking of de-scoping the private link scenario here.
Reason being we need to create a private linked keyvault and then somehow get a key created, which becomes instantly harder because we've made it private and the deployment fails.

We could leverage a pattern of creating it public, and inserting the key then updating to be private, but this would be opaque and quite frankly a bit janky.

Options

  1. Only support creating a public KV, don't mention private
  2. Perhaps we support public with AKS-C, but have a nice message about the private scenario and link to the docs.
  3. Look to support BYO KV and Key for private-link scenarios, but there's a pretty significant RBAC burden here. For an existing KV, is it likely the deploying user will have Owner RBAC on the KV in order to give AKS access? Feels like if you need this, you need to properly understand KMS by rolling it yourself.

Thoughts?

Gordonby added 2 commits September 13, 2022 16:55
… gb-kmsetcd

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 16:18 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 16:18 Inactive
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 16:43 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 16:43 Inactive
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 19:47 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 15, 2022 07:36 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 15, 2022 07:36 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 18, 2022 12:43 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 18, 2022 12:44 Inactive
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 18, 2022 12:46 Inactive
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 09:24 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 09:25 Inactive
@Gordonby Gordonby marked this pull request as ready for review September 20, 2022 09:27
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 09:28 Inactive
@Gordonby
Copy link
Collaborator Author

@khowling - it's ready!

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 09:34 Inactive
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 20, 2022
@Gordonby Gordonby enabled auto-merge (squash) September 20, 2022 09:34
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 09:42 Inactive
@Gordonby Gordonby removed documentation Improvements or additions to documentation Keep Open labels Sep 20, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 09:58 Inactive
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 20, 2022
Gordonby added 2 commits September 20, 2022 11:47
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 20, 2022 10:47 Inactive
@Gordonby Gordonby self-assigned this Sep 21, 2022
bicep/bicepconfig.json Show resolved Hide resolved
bicep/main.bicep Show resolved Hide resolved
bicep/main.bicep Show resolved Hide resolved
helper/src/components/portalnav.js Show resolved Hide resolved
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a good'n

@Gordonby Gordonby merged commit 3a5bbcd into main Sep 21, 2022
@Gordonby Gordonby deleted the gb-kmsetcd branch September 21, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helper-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KMS etcd encryption
2 participants