Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle/reformat of the README and UI #355

Merged
merged 20 commits into from
Sep 2, 2022
Merged

Restyle/reformat of the README and UI #355

merged 20 commits into from
Sep 2, 2022

Conversation

khowling
Copy link
Contributor

@khowling khowling commented Aug 31, 2022

PR Summary

  • Always refer to the project as "AKS Construction", and the UI (formally "helper") to "AKS Construction initializr"
  • Updated README to provide a Quick start guide that should be easy to follow.
  • Update the helper UI to make more streamlined
  • Tidy up GitHub actions deploy UI

New Github Actions Deploy tab (Note the new spacing and labeling)
image

New Readme (Gordon, would like some help here!!)
image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@khowling khowling requested a review from Gordonby August 31, 2022 22:18
@github-actions github-actions bot added documentation Improvements or additions to documentation helper-ui labels Aug 31, 2022
@Gordonby Gordonby marked this pull request as draft September 1, 2022 09:10
@khowling
Copy link
Contributor Author

khowling commented Sep 1, 2022

@Gordonby , I cleaned up the Quick Start formatting now, so happy for it to be merged, but please can you check the rest of the README pls.

I'd love to get this live.

@mosabami are you happy with the rename from helper -> initializr? if not. I can change it back, but still keep the new formatting and README

@Gordonby Gordonby temporarily deployed to azurecirgs September 2, 2022 10:08 Inactive
helper/src/configpresets/principals.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Gordonby Gordonby temporarily deployed to azurecirgs September 2, 2022 11:45 Inactive
@Gordonby Gordonby changed the title Rebrand of the README and UI (helper => initializr) Restyle/reformat of the README and UI Sep 2, 2022
@Gordonby
Copy link
Collaborator

Gordonby commented Sep 2, 2022

@Gordonby , I cleaned up the Quick Start formatting now, so happy for it to be merged, but please can you check the rest of the README pls.

I'd love to get this live.

@mosabami are you happy with the rename from helper -> initializr? if not. I can change it back, but still keep the new formatting and README

We've pulled the rename to initializr for the time being @mosabami.

@Gordonby
Copy link
Collaborator

Gordonby commented Sep 2, 2022

@khowling - we need to also PR this repo to update from "Bicep Accelerator".
https://github.com/Azure/AKS-Landing-Zone-Accelerator#bicep-aks-accelerator

Gordonby
Gordonby previously approved these changes Sep 2, 2022
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gordonby Gordonby marked this pull request as ready for review September 2, 2022 12:25
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khowling khowling merged commit 0aa37c3 into main Sep 2, 2022
@khowling khowling deleted the kh-rebrand branch September 2, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helper-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants