Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AksProperties object in bicep #360

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Refactor AksProperties object in bicep #360

merged 6 commits into from
Sep 2, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Sep 2, 2022 •
edited
Loading

PR Summary

Clsoes #344

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

Gordonby added 5 commits September 1, 2022 14:35
simplified main.json to repro
e10a76e 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Merge branch 'main' of https://github.com/Azure/Aks-Construction into…
228912c 
… gb-ipbug
think this should work
6d84739 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
refactoring properties
174afa4 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Update readme
15ae17f 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 2, 2022 10:01 Inactive
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 2, 2022
@Gordonby Gordonby added test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge and removed documentation Improvements or additions to documentation labels Sep 2, 2022
@Gordonby Gordonby enabled auto-merge (squash) September 2, 2022 10:02
@Gordonby Gordonby self-assigned this Sep 2, 2022
removing readme change. lets do in another pr
3f7067f 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 2, 2022 10:15 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 2, 2022 10:18 Inactive
khowling
khowling approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we pair programmed

@Gordonby Gordonby merged commit f48cb27 into main Sep 2, 2022
@Gordonby Gordonby deleted the gb-ipbug branch September 2, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees

@Gordonby Gordonby

Labels
test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gordonby @khowling