Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Link fix and Automated Workflow Broken Link Checker #366

Merged
merged 9 commits into from
Sep 6, 2022
Merged

Broken Link fix and Automated Workflow Broken Link Checker #366

merged 9 commits into from
Sep 6, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Sep 5, 2022 •
edited
Loading

PR Summary

  1. Fixes broken link
  2. Adds a new workflow that checks the helper and repo for broken links, then logs issues each month
  3. Adds a new step to the Verify Helper workflow to check the Helper (on localhost:3000) for broken links

Closes #365

Here's what the bot created issue looks like on the current live site

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby enabled auto-merge (squash) September 5, 2022 15:31
@Gordonby Gordonby added the ci-cd sample 🤖 Sample code in a GitHub action workflow label Sep 5, 2022
@Gordonby Gordonby changed the title Broken Link Checker Broken Link fix and Automated Workflow Broken Link Checker Sep 5, 2022
@Gordonby Gordonby marked this pull request as draft September 6, 2022 09:50
auto-merge was automatically disabled September 6, 2022 09:50

Pull request was converted to draft

@Gordonby Gordonby marked this pull request as ready for review September 6, 2022 10:20
@Gordonby Gordonby enabled auto-merge (squash) September 6, 2022 10:21
khowling
khowling approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@Gordonby Gordonby merged commit 2551c27 into main Sep 6, 2022
@Gordonby Gordonby deleted the gb-brokenlinks branch September 6, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees
No one assigned
Labels
ci-cd sample 🤖 Sample code in a GitHub action workflow helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link in external site (Aks Previews)
2 participants
@Gordonby @khowling