Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Dapr + Flux race condition #390

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Fixing Dapr + Flux race condition #390

merged 2 commits into from
Sep 13, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Sep 12, 2022

PR Summary

This fixes a bug where if you configured Flux and Dapr, then they would conflict with each other whilst installing simultaneously.

It also addresses another small issue with the default parameter value for upgradeChannel

Closes #385
Closes #389

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 12, 2022 12:49 Inactive
@Gordonby Gordonby marked this pull request as draft September 12, 2022 12:49
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 08:53 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs September 13, 2022 08:53 Inactive
@Gordonby Gordonby marked this pull request as ready for review September 13, 2022 08:53
@Gordonby Gordonby enabled auto-merge (squash) September 13, 2022 08:54
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome fixes, good investigation!!

@Gordonby Gordonby merged commit 578d511 into main Sep 13, 2022
@Gordonby Gordonby deleted the gb-fluxbug branch September 13, 2022 08:56
@joshuadmatthews
Copy link

joshuadmatthews commented Sep 21, 2022

I am having this issue even with the dependencies chained, I can see that flux is fully finished before dapr starts up yet, dapr is the only thing deploying while it is deploying, yet I still get the EtagMismatch error. Any ideas?

@Gordonby
Copy link
Collaborator Author

I am having this issue even with the dependencies chained, I can see that flux is fully finished before dapr starts up yet, dapr is the only thing deploying while it is deploying, I yet still get the EtagMismatch error. Any ideas?

Can you share the full error?
Just redact your subscription Id etc.

@joshuadmatthews
Copy link

joshuadmatthews commented Sep 21, 2022

{
    "status": "Failed",
    "error": {
        "code": "ExtensionOperationFailed",
        "message": "The extension operation failed with the following error:  Request failed to https://management.azure.com/subscriptions/xyz/resourceGroups/abc/providers/Microsoft.ContainerService/managedclusters/aks/extensionaddons/dapr?api-version=2021-03-01. Error code: Conflict. Reason: Conflict.{\n  \"code\": \"EtagMismatch\",\n  \"message\": \"Failed to save managed aks in subscription xyz, resource abc. Operation is not allowed: Another operation is in progress\",\n  \"subcode\": \"PutManagedClusterAndAgentPools_FailedPrecondition\"\n }."
    }
}

@joshuadmatthews
Copy link

I think it may be something else wrong with my cluster, even if I disable remove the flux addon I still get this error.

@joshuadmatthews
Copy link

Deleting my cluster and letting it recreate resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants