Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI improvements and UI tweaks #413

Merged
merged 30 commits into from
Oct 7, 2022
Merged

CNI improvements and UI tweaks #413

merged 30 commits into from
Oct 7, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Sep 21, 2022

PR Summary

CNI

Closes #403 - CNI Overlay networking
Closes #224 - Dynamic Ip addressing
Closes #414 - Max pods per node

UI

image

TODO

  • Add docs links to the UI
  • On selecting Dynamic IP Allocation, force the maxPods to go to 250
  • On selecting Overlay, override the size of the subnets
  • Test Overlay feature deploy
  • Test DIPA feature deploy
  • Test both features together
  • Test if overlay works with default networking
  • Add this CI/CD samples - Add step to scale the cluster #348

UI

Preview warning

Enhanced the preview warning, closes #384
image

Keda preview

Added link to Keda preview, closes #411
image

Other

Also closes #409 by updating the querystring in the window as the user configures
Closes #348 - (Autoscale the cluster as part of CI/CD tests)
Closes #408 - (HelperUI GitHub action workflow using main instead of release tag)

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 21, 2022 21:56 Inactive
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 22, 2022 13:30 Inactive
Gordon Byers added 3 commits September 29, 2022 17:48
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby changed the title CNI improvements CNI improvements and some UI tweaks Sep 29, 2022
@Gordonby Gordonby changed the title CNI improvements and some UI tweaks CNI improvements and UI tweaks Sep 29, 2022
Gordonby added 4 commits September 29, 2022 18:17
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby
Copy link
Collaborator Author

Gordonby commented Oct 3, 2022

Created #421 as i can't deal with the full UX on preview features in this PR. 😄

Gordonby added 5 commits October 3, 2022 09:54
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby marked this pull request as ready for review October 4, 2022 15:11
Gordonby added 2 commits October 4, 2022 16:40
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby requested a review from khowling October 4, 2022 15:48
@Gordonby Gordonby self-assigned this Oct 5, 2022
@Gordonby Gordonby enabled auto-merge (squash) October 5, 2022 15:10
@Gordonby Gordonby disabled auto-merge October 5, 2022 16:54
@Gordonby Gordonby added the enhancement New feature or request label Oct 6, 2022
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby added the test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge label Oct 6, 2022
@Gordonby
Copy link
Collaborator Author

Gordonby commented Oct 6, 2022

@BernieWhite - Any idea why PSRule says this?

Error: Failed to expand parameter file '/home/runner/work/AKS-Construction/AKS-Construction/.github/workflows_dep/AksDeploy-ByoVnet.parameters.json'. Exception calling "GetResources" with "2" argument(s): "Bicep (0.10.61) compilation of '/home/runner/work/AKS-Construction/AKS-Construction/bicep/main.bicep' failed with: Bicep compilation hasn't completed within the timeout window. This can be caused by errors or warnings. Check the Bicep output by running bicep build and addressing any issues."

-> .github/workflows_dep/AksDeploy-ByoVnet.parameters.json : .json [4/4]

https://github.com/Azure/AKS-Construction/actions/runs/3198569850/jobs/5223259003#step:3:70

The bicep builds fine in our deploy stage.

@BernieWhite
Copy link
Contributor

BernieWhite commented Oct 6, 2022

@Gordonby PSRule has a limit it allows Bicep Build to run. By default this is 5 seconds per .bicep file.

See https://azure.github.io/PSRule.Rules.Azure/troubleshooting/#bicep-compilation-timeout

@Gordonby
Copy link
Collaborator Author

Gordonby commented Oct 7, 2022

@Gordonby PSRule has a limit it allows Bicep Build to run. By default this is 5 seconds per .bicep file.

See https://azure.github.io/PSRule.Rules.Azure/troubleshooting/#bicep-compilation-timeout

Great thanks.

It was working for a long time, then stopped... Changing the timeout looks like it's done the job.

@Gordonby Gordonby enabled auto-merge (squash) October 7, 2022 11:46
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bon voyage

@Gordonby Gordonby merged commit 068c967 into main Oct 7, 2022
@Gordonby Gordonby deleted the gb-cnioverlay branch October 7, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helper-ui test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge
Projects
None yet
3 participants