Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Firewall Sku's #423

Merged
merged 8 commits into from
Oct 10, 2022
Merged

Additional Firewall Sku's #423

merged 8 commits into from
Oct 10, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Oct 5, 2022

PR Summary

Adding the ability to customise the Firewall SKU that is deployed.

Closes #422

Includes a nice refactor of the subnet array creation

UI

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby added enhancement New feature or request azure-preview-feature References a preview feature labels Oct 5, 2022
@Gordonby Gordonby self-assigned this Oct 5, 2022
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby marked this pull request as ready for review October 5, 2022 15:09
@Gordonby Gordonby requested a review from a team October 5, 2022 15:09
@Gordonby Gordonby enabled auto-merge (squash) October 5, 2022 15:10
@Gordonby Gordonby disabled auto-merge October 5, 2022 16:55
Gordonby added 2 commits October 5, 2022 18:00
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby added the test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge label Oct 7, 2022
Gordon Byers added 3 commits October 7, 2022 12:53
… gb-fwTest

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby enabled auto-merge (squash) October 10, 2022 13:31
@Gordonby Gordonby merged commit 309547b into main Oct 10, 2022
@Gordonby Gordonby deleted the gb-fwTest branch October 10, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-preview-feature References a preview feature enhancement New feature or request helper-ui test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Firewall Basic SKU
2 participants