-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added in supportability for network watcher and NSG flow logs #425
Conversation
Do you want the baseline changes in here, or are they for another pr? |
@Gordonby I don't mind the baseline changes being in there because they're just key value changes. I have however changed the disabled value back to true, so users will not see this card until we've finished it. There are a few pipeline failures though so need to look into them. |
Yep, moving to disabled is fine. GitHub says that you'll need to update your branch from main, so do that before worrying too much about Ci failures. |
Broken link detector isn't letting this through 😄😄😄 Looks like the coreos domain is gone.
Can you swap it out with this one please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Summary
When enabling NSG flow logs, the pipeline would fail stating that NetworkWatcherRG was not present. This resource group wasn't created at the time the NSG flow logs were getting enabled.
Added in compatibility to support the user to create the resource group first and added in network watcher resource before the flow logs get enabled. This has fixed the issue.
Closes #410
PR Checklist