Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in supportability for network watcher and NSG flow logs #425

Merged
merged 10 commits into from
Oct 14, 2022

Conversation

MattLeach25
Copy link
Contributor

@MattLeach25 MattLeach25 commented Oct 12, 2022

PR Summary

When enabling NSG flow logs, the pipeline would fail stating that NetworkWatcherRG was not present. This resource group wasn't created at the time the NSG flow logs were getting enabled.

Added in compatibility to support the user to create the resource group first and added in network watcher resource before the flow logs get enabled. This has fixed the issue.

Closes #410

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby
Copy link
Collaborator

Do you want the baseline changes in here, or are they for another pr?

@MattLeach25
Copy link
Contributor Author

Do you want the baseline changes in here, or are they for another pr?

@Gordonby I don't mind the baseline changes being in there because they're just key value changes. I have however changed the disabled value back to true, so users will not see this card until we've finished it.

There are a few pipeline failures though so need to look into them.

@Gordonby
Copy link
Collaborator

Do you want the baseline changes in here, or are they for another pr?

@Gordonby I don't mind the baseline changes being in there because they're just key value changes. I have however changed the disabled value back to true, so users will not see this card until we've finished it.

There are a few pipeline failures though so need to look into them.

Yep, moving to disabled is fine.

GitHub says that you'll need to update your branch from main, so do that before worrying too much about Ci failures.

@Gordonby
Copy link
Collaborator

Broken link detector isn't letting this through 😄😄😄

Looks like the coreos domain is gone.

Errors per input

Errors in helper/localsite.html

Can you swap it out with this one please?
https://prometheus-operator.dev/docs/user-guides/getting-started/

Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gordonby Gordonby merged commit 212e11f into main Oct 14, 2022
@Gordonby Gordonby deleted the MattLeachSecureBaseline branch October 14, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling NSG Flow logs will cause a dependency failure
2 participants