-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Traefik as an available ingress controller #440
Conversation
@MattLeach25 Looks good to me. Just make sure to add traefik to the cspell dictionary (cspell.json) @khowling - Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - But i'll let Keith provide the final approval for merge.
Hey Matt, looks great! thanks for catching the case bug for nginx, just a couple of questions for qa.
|
@MattLeach25 I can walk you through these advanced testing scenarios on Monday. Stick some time in. |
Keith has already talked me through the changes so I can get going. If I get stuck I’ll pop up next week :) thanks both. |
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added Traefik as an available ingress controller to postdeploy script and options in the GUI.
Fixed a bug with NGINX where the helm chart would deploy, however there was no pods or services deployed. This turned out to be a typo within the postdeploy script.
This PR covers feature #96
PR Checklist