-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node pool name customisation #462
Conversation
Logic looks good. |
@Gordonby one thing I am was not sure of is whether the text input field should be required (with the red asterik). It's required unless only system node pool exists. It's currently always required. What's your thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an output of the pool name(s) ?
This way if a consuming bicep/pipeline uses AKSC then it'll be easy to grab the poolnames.
@Gordonby suggestions absolutely make sense. I have implemented, tested and committed those. I just want to highlight the commenting out of code block startling line 50 in clusterTab.js. This was clearing vmSKU without any changes in compute type |
PR Summary
User node pool name should be customisable
PR Checklist
As described in issue #461, user node pool is made configurable
In case of only system node pools, the parameter is not set.
If no value provided by user, it defaults to npuser01, the original string that was used