Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix, setting default parameter value #588

Merged
merged 1 commit into from
May 26, 2023
Merged

Bugfix, setting default parameter value #588

merged 1 commit into from
May 26, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented May 26, 2023 •
edited

PR Summary

Spotted in release process.
Fixes a breaking change in anyone consuming network.bicep directly

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress

@Gordonby Gordonby requested a review from samaea May 26, 2023 10:31
@Gordonby Gordonby enabled auto-merge (squash) May 26, 2023 10:32
@Gordonby Gordonby self-assigned this May 26, 2023
samaea
samaea approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@samaea samaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Gordonby Gordonby merged commit 68ed4d6 into main May 26, 2023
87 checks passed
@Gordonby Gordonby deleted the gb-peeredvnetbug branch May 26, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaea samaea samaea approved these changes

Assignees

@Gordonby Gordonby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gordonby @samaea