Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podSubnetID - fixing breaking change #591

Merged
merged 1 commit into from
May 29, 2023
Merged

podSubnetID - fixing breaking change #591

merged 1 commit into from
May 29, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented May 29, 2023 •
edited

PR Summary

A new parameter was added in #570 which did not have a default vaue.
This represents a breaking change, which we want to avoid... so i'm setting the default.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby requested a review from samaea May 29, 2023 09:03
@Gordonby Gordonby self-assigned this May 29, 2023
@Gordonby Gordonby enabled auto-merge (squash) May 29, 2023 09:03
samaea
samaea approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@samaea samaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@Gordonby Gordonby merged commit 15b60fd into main May 29, 2023
69 checks passed
@Gordonby Gordonby deleted the gb-peeredfix branch May 29, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaea samaea samaea approved these changes

Assignees

@Gordonby Gordonby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gordonby @samaea