Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nat Gateway simplification #599

Merged
merged 13 commits into from
Jun 30, 2023
Merged

Nat Gateway simplification #599

merged 13 commits into from
Jun 30, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Jun 23, 2023 •
edited

PR Summary

Closes #598

Additionally takes the preview flag off Overlay networking, and deals with a couple of bicep linting warnings.

UI

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby added the test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge label Jun 23, 2023
@Gordonby Gordonby marked this pull request as ready for review June 29, 2023 13:52
@Gordonby Gordonby enabled auto-merge (squash) June 29, 2023 13:53
@Gordonby Gordonby merged commit 5e360b5 into main Jun 30, 2023
54 checks passed
@Gordonby Gordonby deleted the gb-issuerurl branch June 30, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

@MattLeach25 MattLeach25 Awaiting requested review from MattLeach25

Assignees
No one assigned
Labels
helper-ui test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify Nat Gateway selection
2 participants
@Gordonby @khowling