Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing a more secure option should not come with a warning - #621 #623

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

asalbers
Copy link
Contributor

@asalbers asalbers commented Jul 27, 2023

PR Summary

Wanted more encouraging language for those that are choosing a private cluster. Changed two files clusterTab.js and principals.json

Fixes #621

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

image
image

@khowling
Copy link
Contributor

This looks good, thank you @asalbers. @asalbers @mosabami , do you mined it we change the message slightly, I dont think its necessarily the best option for every company / environment / workload. Can we change to something like "Most secure option for your apps, but requires most involved access management" (can remove the "Note" text)

@asalbers
Copy link
Contributor Author

asalbers commented Aug 7, 2023

This looks good, thank you @asalbers. @asalbers @mosabami , do you mined it we change the message slightly, I dont think its necessarily the best option for every company / environment / workload. Can we change to something like "Most secure option for your apps, but requires most involved access management" (can remove the "Note" text)

Updated

@Gordonby Gordonby enabled auto-merge (squash) August 17, 2023 17:25
@Gordonby
Copy link
Collaborator

All the checks are passing now @mosabami . When you approve, the changes will merge, and as long as there's no unreleased bicep changes in main - this should go straight out.

@Gordonby Gordonby merged commit a4bc33c into main Aug 31, 2023
33 checks passed
@Gordonby Gordonby deleted the aa-issue-621 branch August 31, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing a more secure option should not come with a warning
4 participants