Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'always display cluster get-credentials' checkbox option to helper #628

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Added 'always display cluster get-credentials' checkbox option to helper #628

merged 5 commits into from
Aug 10, 2023

Conversation

pjlewisuk
Copy link
Contributor

PR Summary

  • Added "Always show the 'az aks get-credentials' command to quickly connect to your new cluster" checkbox to the helper
  • Set this option to default to "true" (i.e. on)
  • Refactored some of the post-deploy logic to separate the connection command from the post-deploy commands
  • Added logic for private clusters (which don't need a cluster connection string as we use the invoke command instead)
  • Fixed indentation on some adjacent code

Fixes #614

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

Screenshot:

Screenshot 2023-08-08 111957

@pjlewisuk
Added check-box to always get cluster creds
43c7ba5 
Set getCreds default to true to enable this option
Refactored some post_deploy strings and commands to make this work
@pjlewisuk
Fixed indentation
71d2c2b
@pjlewisuk
Changed label and removed commented lines
aa848a4
@pjlewisuk pjlewisuk requested review from khowling and samaea and removed request for khowling August 8, 2023 09:29
@pjlewisuk pjlewisuk requested a review from khowling August 8, 2023 09:29
khowling
khowling approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reviewed over teams, great job Paul! Thanks for sticking with this tricky code

@pjlewisuk pjlewisuk removed the request for review from samaea August 10, 2023 07:57
@pjlewisuk pjlewisuk merged commit cc9b612 into main Aug 10, 2023
6 of 8 checks passed
@pjlewisuk pjlewisuk deleted the paullewis-614-aks-get-creds branch August 10, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees
No one assigned
Labels
helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Always include get credentials command when provisioning via bash or PowerShell
2 participants
@pjlewisuk @khowling