Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatic Node Image Upgrade for node versions #1486

Closed
palma21 opened this issue Mar 11, 2020 · 18 comments
Closed

[Feature] Automatic Node Image Upgrade for node versions #1486

palma21 opened this issue Mar 11, 2020 · 18 comments

Comments

@palma21
Copy link
Member

palma21 commented Mar 11, 2020

Providing an opt-in feature for Automated Node Upgrade
Automating the Node Upgrade feature ->#893

https://docs.microsoft.com/en-us/azure/aks/upgrade-cluster#set-auto-upgrade-channel

@palma21 palma21 self-assigned this Mar 11, 2020
@palma21 palma21 added this to Backlog (Committed Items) in Azure Kubernetes Service Roadmap (Public) Mar 11, 2020
@jluk jluk changed the title Feature: Node Auto Upgrade [Feature] Node Auto Upgrade Mar 11, 2020
@jluk jluk moved this from Backlog (Committed) to Planned in Azure Kubernetes Service Roadmap (Public) Mar 17, 2020
@jluk jluk changed the title [Feature] Node Auto Upgrade [Feature] Automatic Node Image Upgrade May 15, 2020
@jluk jluk changed the title [Feature] Automatic Node Image Upgrade [Feature] Automatic Node Image Upgrade for node versions Jun 23, 2020
@ghost ghost added the stale Stale issue label Aug 23, 2020
@ghost
Copy link

ghost commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

@palma21 palma21 added feature-request Requested Features and removed stale Stale issue labels Aug 23, 2020
@ezYakaEagle442
Copy link

Hi @jluk and @palma21 any update on this issue please ?

@palma21 palma21 moved this from Planned (Committed) to In Progress (Development) in Azure Kubernetes Service Roadmap (Public) Nov 11, 2020
@palma21 palma21 moved this from In Progress (Development) to Public Preview (Shipped & Improving) in Azure Kubernetes Service Roadmap (Public) Apr 14, 2021
@ghost ghost added the action-required label May 10, 2021
@palma21 palma21 removed the feature label May 12, 2021
@ghost ghost removed the action-required label May 12, 2021
@pietervincken
Copy link

@palma21 Hi, is there any documentation available on how to enable / use this? I've only come across the Github Actions documentation which is a different solution from this I assume?

@denniszielke
Copy link

"--auto-upgrade-channel node-image" is a new parameter in the aks preview cli

@denniszielke
Copy link

I have also registered the following preview feature (not sure if that is still required since it is public preview now).
az feature register --namespace "Microsoft.ContainerService" --name "NodeImageUpgradePreview"

@pietervincken
Copy link

I had to do az feature register --namespace Microsoft.ContainerService -n AutoUpgradePreview as well. It seems to work now. Thanks!

@ivanthelad
Copy link

@palma21 Hi, is there any documentation available on how to enable / use this? I've only come across the Github Actions documentation which is a different solution from this I assume?

@pietervincken @denniszielke the docs don't state anything about the nodeimagepreview, apparently its enough just to supply the node-image. i think this was recent change in the docs
https://docs.microsoft.com/en-us/azure/aks/upgrade-cluster#set-auto-upgrade-channel

@asubmani
Copy link

@palma21 Is this GA? I don't get any results for the below command
az feature list -o table --query "[?contains(name, 'Microsoft.ContainerService/AutoUpgradePreview')].{Name:name,State:properties.state}"

However when I do az aks update --help | grep auto I can see the --auto-upgrade-channel I am using Az cli 2.25.0

As per the GH project, this is still in public preview.

@palma21
Copy link
Member Author

palma21 commented Jul 18, 2021

It's still in preview, will be GAing soon.

@trhumphries
Copy link

When I set the upgrade channel as node image
az aks update --auto-upgrade-channel node-image --resource-group rg-trh-qa --name trh-qa

It returns

"autoUpgradeProfile": {
"upgradeChannel": "none"
},

I've registered the AutoUpdatePreview and the NodeImageUpgradePreview
Is there something else I need to do?

@sureshgoli25
Copy link

When this feature would be GA? Soon means in days or weeks or months or years?

@damienpontifex
Copy link

Are the upgrade channels inherited?

i.e. if you specify patch, you get patch and node-image updates. if you specify stable, you get stable, patch and node-image

We'd like both patch and node-image in our setup when adopting this to begin with, but I can't see anywhere that you get both by applying a higher upgrade channel

@siegenthalerroger
Copy link

@damienpontifex #2429 is tracking that specific case seeing as the auto-upgrade node-image and aks are so close to GA having it seperate seems prudent.

@damienpontifex
Copy link

@siegenthalerroger auto upgrade is now GA according to latest release https://github.com/Azure/AKS/releases/tag/2021-11-11

It just surprised me that this wasn't in the feature prior. Seems weird that I'd want say stable but that would somehow imply I didn't want node image updates in between stable version releases. Anyway, we can keep kured that we're currently using to update nodes, while still adopting patch or stable for the kubernetes version updates until the feature is enhanced

@siegenthalerroger
Copy link

@damienpontifex yes it's GA now, however I believe the behaviour is still such that one must choose between node-image upgrades (weekly) or the k8s upgrades. Unless the documentation says something else that would be my assumption (and to the best of my knowledge this is the case).

@naioja
Copy link

naioja commented Nov 22, 2021

@siegenthalerroger the node-image option will update only the OS image and patch/stable/rapid will update both OS+K8S

@siegenthalerroger
Copy link

@naioja yes patch/stable/rapid will update both, however it won't be weekly right? Rather the node-image will only get updated when a k8s update triggers the nodes to update...

@palma21
Copy link
Member Author

palma21 commented Dec 7, 2021

GA - closing

Additional discussions on cumulative in #2429

@palma21 palma21 closed this as completed Dec 7, 2021
@palma21 palma21 moved this from Public Preview (Shipped & Improving) to Generally Available (Done) in Azure Kubernetes Service Roadmap (Public) Dec 7, 2021
@Azure Azure locked as resolved and limited conversation to collaborators Jan 6, 2022
@palma21 palma21 moved this from Generally Available (Done) to Archive (GA older than 1 month) in Azure Kubernetes Service Roadmap (Public) Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Requested Features Upgrade
Projects
Azure Kubernetes Service Roadmap (Pub...
Archive (GA older than 1 month)
Development

No branches or pull requests