Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Linter Rules From Latest Bicep Release & Fix Hub Networking Conditionals #148

Merged
merged 8 commits into from
Feb 15, 2022
Merged

Update Linter Rules From Latest Bicep Release & Fix Hub Networking Conditionals #148

merged 8 commits into from
Feb 15, 2022

Conversation

jtracey93
Copy link
Contributor

Overview/Summary

Update Linter Rules From Latest Bicep Release https://github.com/Azure/bicep/releases/tag/v0.4.1272

This PR fixes/adds/changes/removes

  1. Update bicepconfig.json's for each module with latest supported linter rules for Bicep
  2. Add #disable-next-line to required modules for linter suppression
  3. Fixed Public IP, Spoke Networking & Hub Networking module with new parRegion parameter for location selection
  4. Fixed conditionals in Hub Networking Module for Bastion & Azure Firewall
  5. Fixes ADO 97041

Breaking Changes

None

Testing Evidence

Linting Rules Passed For Bicep Build
image

Hub Networking Deployment Succeeded
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 14, 2022
@jtracey93 jtracey93 added Area: Networking bug Something isn't working enhancement New feature or request hygiene things related to testing, issue triage etc. labels Feb 14, 2022
ejhenry
ejhenry previously approved these changes Feb 14, 2022
View reviewed changes
@jtracey93 jtracey93 temporarily deployed to BicepUnitTests February 14, 2022 21:57 Inactive
@jtracey93 jtracey93 merged commit 312174f into main Feb 15, 2022
@jtracey93 jtracey93 deleted the linter-rule-breaking-change-fix branch February 15, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry approved these changes

Assignees
No one assigned
Labels
Area: Networking bug Something isn't working enhancement New feature or request hygiene things related to testing, issue triage etc. Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtracey93 @ejhenry