Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests for bicep and close PR job #149

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Feb 15, 2022

Overview/Summary

This PR updates the unit tests for bicep files and the close PR job.

This PR fixes/adds/changes/removes

  1. Updated .github\workflows\cleanup-on-close-pr.yml to use standard shell instead of container based action outputs for more visibility into logs
  2. Updated .github\workflows\bicep-build-to-validate.yml by removing deployment/E2E tests of modules as these will move to ADO shortly.
    • These tests only now build the bicep files, and fail if any modules fail to build, and check against the bicep linter using the bicepconfig.json files in each module

Breaking Changes

None

Testing Evidence

Tests have just removed or converted existing functionality and commands they were using. Linters will confirm they are valid YAML files

Bicep Unit Tests - Tested Here: https://github.com/Azure/ALZ-Bicep/runs/5198665645?check_suite_focus=true

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jtracey93 jtracey93 added the hygiene things related to testing, issue triage etc. label Feb 15, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 15, 2022
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Feb 15, 2022
@jtracey93 jtracey93 merged commit 011e7e8 into main Feb 15, 2022
@jtracey93 jtracey93 deleted the adjust-testing-pt1 branch February 15, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hygiene things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant