Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PSRule without parameter files #206 #207

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

BernieWhite
Copy link
Contributor

@BernieWhite BernieWhite commented Apr 15, 2022

Overview/Summary

Adds integration with PSRule for Azure for testing repository code with Azure Well-Architected Framework.

Working towards #206

This PR fixes/adds/changes/removes

  1. Added PSRule integration using VSCode and GitHub Actions. Parameter files/ Bicep tests not included.

Breaking Changes

N/A

Testing Evidence

Modules resources are not being processed yet until we have snippets to expand them.

Rules processed: 124, failed: 0, errored: 0
Run Azure/ALZ-Bicep/2170788848 completed in 00:00:07.1681704

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 15, 2022
@BernieWhite BernieWhite marked this pull request as ready for review April 15, 2022 03:38
@BernieWhite
Copy link
Contributor Author

@jtracey93 Initial effort without parameter files. Which I understood that you didn't want merged yet, because we would work towards snippets for deployment/ testing. Let me know if there is anything else you feel we need to do to get this PR merged.

ps-rule.yaml Outdated Show resolved Hide resolved
@jtracey93 jtracey93 added hygiene and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 19, 2022
@jtracey93 jtracey93 self-assigned this Apr 19, 2022
Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jtracey93 jtracey93 merged commit 8f4089d into Azure:ps-rule Apr 25, 2022
@BernieWhite BernieWhite deleted the bewhite/ps-rule-integration branch April 25, 2022 13:44
jtracey93 added a commit that referenced this pull request Sep 5, 2022
* Initial PSRule without parameter files #206 (#207)

* Initial PSRule without parameter files #206

* Update triggers and reference extension

* Separate job to ignore build bicep code

* Update PSRule options to include Bicep samples

* PSRule baseline and minium samples (#236)

* Update exclusions and complete AZ params for PIPs (#242)

* Update exclusions and complete AZ params for PIPs

* Add additional comments

* Final updates for merge (#252)

* psrule sample fixes

* fix github linter for PSRule MD

* typo fix

* update rules

Co-authored-by: Bernie White <bewhite@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants