Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tag property for virtualNetworks resource #231

Merged
merged 1 commit into from
May 6, 2022
Merged

Added tag property for virtualNetworks resource #231

merged 1 commit into from
May 6, 2022

Conversation

johnlokerse
Copy link
Contributor

@johnlokerse johnlokerse commented May 6, 2022 •
edited

Overview/Summary

Found out that I was missing the tag property during template testing.

This PR fixes/adds/changes/removes

  1. Added parTags to the virtualNetwork resource in spokeNetworking.bicep

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 6, 2022
@johnlokerse
Copy link
Contributor Author

The "dead links" look fine to me. Can you rerun the action for me @jtracey93?

@jtracey93
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added enhancement New feature or request Area: Networking Area: Non-Resource Specific things like tags, location etc. and removed Needs: Triage 🔍 Needs triaging by the team labels May 6, 2022
jtracey93
jtracey93 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 self-assigned this May 6, 2022
@jtracey93 jtracey93 added this to Triage in ALZ Bicep Public Project via automation May 6, 2022
@jtracey93 jtracey93 moved this from Triage to In progress in ALZ Bicep Public Project May 6, 2022
@jtracey93 jtracey93 merged commit 2c0ea75 into Azure:main May 6, 2022
ALZ Bicep Public Project automation moved this from In progress to Done May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@jtracey93 jtracey93

Labels
Area: Networking Area: Non-Resource Specific things like tags, location etc. enhancement New feature or request
Projects
No open projects
ALZ Bicep Public Project
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnlokerse @jtracey93