New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python SDK to Track 2 #1649
Conversation
@@ -0,0 +1,23 @@ | |||
FROM registry.access.redhat.com/ubi8/nodejs-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be LTS after 2021-10-26 which will be nodejs-16. Nodejs 14 will be in maintenance but maybe a comment to change this image or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, AutoRest warns about versions higher than 14. We can update the base image once this warning goes away:
WARNING: AutoRest has not been tested with Node versions greater than v14.
@25region please commit other changes together here. Im not gonna merge this without the changes. This PR now is bit out of context as it looks like it is contains all the changes, but it does not. |
Please rebase pull request. |
@mjudeikis |
fa8adb6
to
6ee6cb5
Compare
a5be3e2
to
22d7110
Compare
@mjudeikis - reverted to switch only Python SDK to Track 2.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjudeikis - reverted to switch only Python SDK to Track 2.
az aro create
is getting the following error:(InvalidParameter) The provided worker VM size 'Standard_D2s_v3' is invalid.
Gonna leave this here :) Are you using development RP?
Line 29 in 5efde46
if requiredD2sV3Workers { |
Overall looks good just tests and nits
.../services/redhatopenshift/mgmt/2020-04-30/redhatopenshift/redhatopenshiftapi/interfaces.go-e
Outdated
Show resolved
Hide resolved
pkg/client/services/redhatopenshift/mgmt/2020-04-30/redhatopenshift/models.go-e
Outdated
Show resolved
Hide resolved
...s/redhatopenshift/mgmt/2021-09-01-preview/redhatopenshift/redhatopenshiftapi/interfaces.go-e
Outdated
Show resolved
Hide resolved
22d7110
to
2fe5b65
Compare
2fe5b65
to
10a73b2
Compare
Thanks for this! Next step is to upstream this to azure/azure-cli repo! :) |
Which issue this PR addresses:
Migrate ARO cli extension to SDK v2
What this PR does / why we need it:
The aro CLI extension currently uses v1 of Azure SDK for Python, which will be decommissioned in early 2022.
The goal of this story is to convert the aro cli extension to work with Azure SDK v2. There will be breaking changes after bumping the SDK to v2 and we need to guarantee all the existing functionalities are working with the new SDK version.
Test plan for issue:
az aro
commands with the new Track 2 extensionIs there any documentation that needs to be updated for this PR?
Follow up stories will need to be created: