Add a test for NodeDrainer reconciler (node controller) #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
added
help wanted
cadenmarchese
force-pushed
the
nodecontroller-testreconcile
branch
from
a85fe38
to
1d458fa
Compare
cadenmarchese
added
priority-low
cadenmarchese
requested review from
bennerv,
hawkowl,
jewzaam,
mwoodson,
petrkotas and
rogbas
as code owners
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hawkowl
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes #1686
Currently we only unit test external functions in node_controller.go. This PR is meant to add unit test coverage for the reconciler method itself.
What this PR does / why we need it:
Test plan for issue:
Unit tests pass, and code coverage is acceptable.
Is there any documentation that needs to be updated for this PR?
No