Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aks-owned windows VHD #187

Merged
merged 3 commits into from
Aug 12, 2020
Merged

add aks-owned windows VHD #187

merged 3 commits into from
Aug 12, 2020

Conversation

mainred
Copy link
Member

@mainred mainred commented Aug 5, 2020 •
edited

copy aks-engine build windows resource to agentbaker.

@mainred
Copy link
Member Author

mainred commented Aug 11, 2020

@AbelHu , could you please take a look?
As we don't support 1.19 in AKS, and this is to support latest change in aks-engine. Later I will build and publish a 20h1 based vhd and add it back to aks-engine for test.
After the first try, the vhd published here is not responsible for aks-engine.

AbelHu
AbelHu reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create a folder Windows/WindowsServer2019 under /vhdbuilder/release-notes/?

vhdbuilder/packer/collect-windows-logs.ps1 Outdated Show resolved Hide resolved
vhdbuilder/packer/collect-windows-logs.ps1 Outdated Show resolved Hide resolved
vhdbuilder/packer/configure-windows-vhd.ps1 Outdated Show resolved Hide resolved
vhdbuilder/packer/collect-windows-logs.ps1 Outdated Show resolved Hide resolved
@mainred mainred changed the title WIP: add aks-owned windows VHD add aks-owned windows VHD Aug 12, 2020
@mainred mainred merged commit 03d7887 into master Aug 12, 2020
@mainred mainred deleted the vhd-windows branch September 13, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuto2 xuto2 xuto2 left review comments

@AbelHu AbelHu AbelHu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mainred @xuto2 @AbelHu