Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add windows server 2019 12B patch #481

Merged
merged 1 commit into from
Dec 15, 2020
Merged

chore: Add windows server 2019 12B patch #481

merged 1 commit into from
Dec 15, 2020

Conversation

mainred
Copy link
Member

@mainred mainred commented Dec 15, 2020

@mainred mainred requested a review from AbelHu December 15, 2020 03:02
@@ -149,7 +149,7 @@ function Test-FilesToCacheOnVHD
function Test-PatchInstalled
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to update the base image to 17763.1637.2012040632?
WindowsServer MicrosoftWindowsServer 2019-Datacenter-Core-smalldisk MicrosoftWindowsServer:WindowsServer:2019-Datacenter-Core-smalldisk:17763.1637.2012040632 17763.1637.2012040632

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a must. We can update the image to stable 12B after it's released

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1204 was released before 12B. I think that we should always follow the principal to install the latest security patch in the latest Windows OS image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have such a principle? Take a look at this please Azure/aks-engine#3692

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always better to check the base image and then update the image before installing a new patch. You can go ahead if you fully understand what it is. Otherwise, we need more effort to clarify why we do not install the latest patch in the latest base image but in an older base image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think we may lost something, I don't mind we have more test in vhdtest to check.

@mainred mainred merged commit dc933b3 into master Dec 15, 2020
@mainred mainred deleted the qinhao/win-12b branch January 29, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants