-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Reload secrets from Key Vault #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ff7e8
to
a2b1afc
Compare
avanigupta
commented
Apr 1, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 20, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
zhenlan
reviewed
Apr 20, 2021
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
zhenlan
reviewed
Apr 20, 2021
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
zhenlan
reviewed
Apr 21, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
zhenlan
reviewed
Apr 21, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 21, 2021
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Show resolved
Hide resolved
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
...xtensions.Configuration.AzureAppConfiguration/AzureKeyVaultReference/CachedKeyVaultSecret.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Constants/ErrorMessages.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 22, 2021
...osoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationKeyVaultOptions.cs
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 28, 2021
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
1b9069a
to
c2945db
Compare
c2945db
to
0ff018b
Compare
Block concurrent network operations (#254)
0ff018b
to
e1589db
Compare
jimmyca15
reviewed
May 3, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
May 3, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
May 3, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
May 3, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Show resolved
Hide resolved
jimmyca15
reviewed
May 3, 2021
...ns.Configuration.AzureAppConfiguration/AzureKeyVaultReference/AzureKeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces two new APIs which allow users to opt-in for periodically reloading secrets and certificates from Key Vault:
Set refresh interval for individual keys of Key Vault references in App Config:
This method allows users to set a refresh interval per key of Key Vault references. The API can be called multiple times to register multiple keys of Key Vault references for refresh.
Set refresh interval for all Key Vault references in App Config:
This method allows users to set a refresh interval for all Key Vault references which do not have individual refresh intervals.
Usage example:
If your App Configuration has the following Key Vault references:
You can set different refresh intervals for any/all of your secret references:
Notes:
SetSecretRefreshInterval
does not monitor the value of a key in App Config. For monitoring the value in AppConfig, use theConfigureRefresh
API to register keys for refresh.SetSecretRefreshInterval
is not invoked, secrets will not be automatically reloaded from Key Vault. In this case, secrets would be reloaded only if any of the following occur:ConfigureRefresh
API, and the reference value changes in App Config.IConfigurationRefresher
will not update the value for a Key Vault secret until the cached value for that secret has expired.Fix #248 and #142.