Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azurekid/bugfix/dataconnector validator #4738

Merged

Conversation

azurekid
Copy link
Contributor

Required items, please complete

Change(s):

  • Updated syntax for .script\dataConnectorValidator.ts
  • Updated syntax for .script\utils\dataConnector.ts
  • Updated syntax for .script\utils\dataConnectorCheckers\dataTypeChecker.ts

Reason for Change(s):

  • An error occurs when adding a data connector for a built-in Azure Log Source

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • N/A

Testing Completed:

  • No

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

@azurekid
Copy link
Contributor Author

Guys,
Do you need any more information on this, or is there anything I can help with?
This is already open and assigned for more than a month without any update
@vmanojreddy @v-dvedak @oshezaf

@oshezaf
Copy link
Contributor

oshezaf commented Jun 1, 2022

Not sure what it is even about :-). Tagging @ashishsyal and @ms-sapangoel to support.

@azurekid
Copy link
Contributor Author

azurekid commented Jun 1, 2022

Not sure what it is even about :-). Tagging @ashishsyal and @ms-sapangoel to support.

Thanks for picking it up. Much appreciated 😉

@ms-sapangoel
Copy link
Contributor

@azurekid data connector validations are added for data connector for data connectors that are based on AzureDevOpsAuditing table. I didn't find any data connector that is based on this table. Do you have plan to add a data connector that is based on this table?

@azurekid
Copy link
Contributor Author

@azurekid data connector validations are added for data connector for data connectors that are based on AzureDevOpsAuditing table. I didn't find any data connector that is based on this table. Do you have plan to add a data connector that is based on this table?

Hi @ms-sapangoel I indeed created a DataConnector for AzureDevOps auditing incl. a functionApp to configure the Azure DevOps stream configuration. See PR: #4729

This data connector failed in the validation script, and therefor I created a PR to update the script.

@NikTripathi NikTripathi merged commit 45157c3 into Azure:master Sep 8, 2022
@azurekid azurekid deleted the azurekid/bugfix/dataconnectorValidator branch October 28, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants