Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secured params and Added additional TVM API call. #6596

Closed
wants to merge 1 commit into from
Closed

Secured params and Added additional TVM API call. #6596

wants to merge 1 commit into from

Conversation

anders-alex
Copy link
Contributor

@anders-alex anders-alex commented Nov 10, 2022 •
edited

Required items, please complete

Change(s):

  • Secured the Logic Apps parameters so the secret is not exposed in clear text after deployment.
  • Removed "UserName" ARM parameter and hardcoded generic display name for Log Analytics connector to remove confusion.
  • Added additional TVM API call to get additional information into Log Analytics.

Reason for Change(s):

  • Secrets in clear text is not a good idea.
  • Critical TVM information was missing from the solution.

Version Updated:

  • N/A

Testing Completed:

  • Yes, deployed in test environment and confirmed data was getting ingested into Log Analytics.

Checked that the validations are passing and have addressed any issues that are present:

  • No KQL or YAML.

@anders-alex anders-alex requested review from a team as code owners November 10, 2022 21:56
@anders-alex
Copy link
Contributor Author

@microsoft-github-policy-service agree

@v-spadarthi v-spadarthi added the Playbook Playbook specialty review needed label Nov 11, 2022
@anders-alex anders-alex marked this pull request as draft November 15, 2022 03:28
@anders-alex
Copy link
Contributor Author

Additional requirements being worked on. Will submit when complete.

@anders-alex anders-alex deleted the M365-Security-Posture-Enhancements branch December 3, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rahul0216 rahul0216

@manishkumar1991 manishkumar1991

@v-spadarthi v-spadarthi

Labels
Playbook Playbook specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anders-alex @rahul0216 @manishkumar1991 @v-spadarthi