Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added a spec to describe the type casting we recommend to do on behalf of the user #803

Merged
merged 76 commits into from
Apr 10, 2024
Merged

feat: Added a spec to describe the type casting we recommend to do on behalf of the user #803

merged 76 commits into from
Apr 10, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Overview/Summary

  • Added a spec to describe the type casting we recommend to do on behalf of the user
  • Added an example for a boolean parameter & an int array parameter
    image

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner April 1, 2024 20:13
@AlexanderSehr AlexanderSehr self-assigned this Apr 1, 2024
@AlexanderSehr AlexanderSehr added Type: Documentation 📄 Improvements or additions to documentation Language: Bicep 💪 This is related to the Bicep IaC language labels Apr 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still and removed Needs: Triage 🔍 Maintainers need to triage still labels Apr 1, 2024
@jtracey93
Copy link
Contributor

@AlexanderSehr can you resolve the conflicts here please :)

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr can you resolve the conflicts here please :)

Done @jtracey93

@AlexanderSehr @eriqua
Update docs/content/specs/bicep/_index.md
920093e 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 2, 2024 17:13
@AlexanderSehr AlexanderSehr mentioned this pull request Apr 2, 2024
Merged
11 tasks
eriqua
eriqua reviewed Apr 4, 2024
View reviewed changes
docs/content/specs/bicep/_index.md
{{< tabs "intArrayString" >}}
{{< tab "Before" >}}

```bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this example change based on #817 ?
Also why zonesValue instead of zones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should yes, @eriqua. Updated it.

I think I called it zoneValues to make it explicit that I'm not refering to a property or something. Anyways, changed it to zones.

@AlexanderSehr AlexanderSehr mentioned this pull request Apr 7, 2024
Merged
11 tasks
eriqua
eriqua approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 5a0362f into Azure:main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Language: Bicep 💪 This is related to the Bicep IaC language Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexanderSehr @jtracey93 @eriqua