Table batch actions update-replace and update-merge do not respect If-Match etag #1233
Assignees
Comments
|
The fix appears to be: diff --git a/src/table/batch/TableBatchOrchestrator.ts b/src/table/batch/TableBatchOrchestrator.ts
index 0bbbb1f..4876a65 100644
--- a/src/table/batch/TableBatchOrchestrator.ts
+++ b/src/table/batch/TableBatchOrchestrator.ts
@@ -486,13 +486,14 @@ export default class TableBatchOrchestrator {
updatedContext.request = request;
let partitionKey: string;
let rowKey: string;
+ const ifmatch: string = request.getHeader("if-match") || "*";
({ partitionKey, rowKey } = this.extractRowAndPartitionKeys(request));
response = await this.parentHandler.updateEntity(
request.getPath(),
partitionKey,
rowKey,
- request.params as BatchTableUpdateEntityOptionalParams,
+ { ifMatch: ifmatch, ...request.params } as BatchTableUpdateEntityOptionalParams,
updatedContext,
batchID
);
@@ -614,13 +615,14 @@ export default class TableBatchOrchestrator {
updatedContext.request = request;
let partitionKey: string;
let rowKey: string;
+ const ifmatch: string = request.getHeader("if-match") || "*";
({ partitionKey, rowKey } = this.extractRowAndPartitionKeys(request));
response = await this.parentHandler.mergeEntity(
request.getPath(),
partitionKey,
rowKey,
- request.params as BatchTableMergeEntityOptionalParams,
+ { ifMatch: ifmatch, ...request.params } as BatchTableMergeEntityOptionalParams,
updatedContext,
batchID
); |
23 tasks
edwin-huber
added a commit
to edwin-huber/Azurite
that referenced
this issue
Jan 18, 2022
… batch orchestrator / proxy class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which service(blob, file, queue, table) does this issue concern?
table
Which version of the Azurite was used?
Locally running version of #1157
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
Git clone
What's the Node.js version?
16.13.0
What problem was encountered?
Table batch action update-replace and update-merge do not seem to respect etag (If-Match) conditions.
Steps to reproduce the issue?
Please be sure to remove any PII or sensitive information before sharing!
The debug log will log raw request headers and bodies, so that we can replay these against Azurite using REST and create tests to validate resolution.
Have you found a mitigation/solution?
The text was updated successfully, but these errors were encountered: