Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any weak etag even if it doesn't match the pattern (412 should happen) #1231

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Allow any weak etag even if it doesn't match the pattern (412 should happen) #1231

merged 4 commits into from
Feb 16, 2022

Conversation

joelverhagen
Copy link
Contributor

Fix #1229

This is pretty low priority, but I wanted to start with an easy bug fix as I ramp up on this repository. This is only my 3rd PR 😄.

Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joel! Seems the change is only for Table. If so, can you help move the checkEtagIsInvalidFormat from common into table/utils.ts?

@joelverhagen
Copy link
Contributor Author

Good call. Done. There was another pre-existing table-only util that I moved too.

@joelverhagen
Copy link
Contributor Author

@XiaoningLiu - could this be merged? Or are there more changes I should do?

@XiaoningLiu XiaoningLiu merged commit a5f0fb4 into Azure:main Feb 16, 2022
@joelverhagen joelverhagen deleted the jver-weak-etag branch February 16, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table service returns 400 not 412 for an unexpected weak etag
2 participants