Some minor issue fixs found during release check

.vscodeignore

@@ -8,6 +8,7 @@ azure-pipelines.yml
 .lintstagedrc
 .gitignore
 .npmignore
+.dockerignore
 Dockerfile
 __blobstorage__
 typings

BreakingChanges.md

@@ -6,11 +6,9 @@
 
 - [Breaking] By default Azurite will block requests with unsupported headers or parameters which may impact data integrity.
   - Skip this by switching to loose mode by Azurite configuration parameter `--loose`.
-- [Breaking] Apply `LokiFsStructuredAdapter` as default blob metadata loki adapter to improve performance.
-  - This version cannot guarantee compatible with persisted database models file by previous version. Remove previous metadata file and restart Azurite in case any errors.
 - [Breaking] Azurite updates underline metadata schema which does not compatible with previous versions.
   - This version cannot guarantee compatible with persisted database models file by previous version. Remove previous metadata file and restart Azurite in case any errors.
 
 ## 2019.11 Version 3.3.0-preview
 
-- [Breaking] This version cannot guarantee compatible with persisted database models file by previous version. Remove previous metadata file and restart Azurite in case any errors.
+- [Breaking] This version cannot guarantee compatible with persisted database models file by previous version. Remove previous metadata file and restart Azurite in case any errors.

ChangeLog.md

@@ -14,8 +14,6 @@
 
 Blob:
 
-- [Breaking] Apply `LokiFsStructuredAdapter` as default blob metadata loki adapter to improve performance.
-  - This version cannot guarantee compatible with persisted database models file by previous version. Remove previous metadata file and restart Azurite in case any errors.
 - [Breaking] Azurite updates underline metadata schema which does not compatible with previous versions.
   - This version cannot guarantee compatible with persisted database models file by previous version. Remove previous metadata file and restart Azurite in case any errors.
 - List blocks will filter the returned block list with input BlockListingFilter.
@@ -43,7 +41,7 @@ Queue:
 
 - AllowedHeaders and ExposedHeaders are optional now when setting CORS.
 - Fix Put message fail with max messagettl.
-- Updated message size calculation when checking 64KB limitation. 
+- Updated message size calculation when checking 64KB limitation.
 
 ## 2019.11 Version 3.3.0-preview
 

src/blob/persistence/LokiBlobMetadataStore.ts

@@ -7,7 +7,6 @@ import {
   convertDateTimeStringMsTo7Digital,
   rimrafAsync
 } from "../../common/utils/utils";
-import { lfsa } from "../../common/utils/utils";
 import StorageErrorFactory from "../errors/StorageErrorFactory";
 import * as Models from "../generated/artifacts/models";
 import { LeaseStatusType } from "../generated/artifacts/models";
@@ -100,7 +99,6 @@ export default class LokiBlobMetadataStore
 
   public constructor(public readonly lokiDBPath: string) {
     this.db = new Loki(lokiDBPath, {
-      adapter: new lfsa(),
       autosave: true,
       autosaveInterval: 5000
     });
@@ -209,12 +207,6 @@ export default class LokiBlobMetadataStore
     if (this.isClosed()) {
       await rimrafAsync(this.lokiDBPath);
 
-      // Remove separate metadata collection json files generated by LokiFsStructuredAdapter
-      const searchScope = 20; // Should be larger than number of collections for every loki database
-      for (let i = 0; i < searchScope; i++) {
-        await rimrafAsync(`${this.lokiDBPath}.${i}`);
-      }
-
       return;
     }
     throw new Error(`Cannot clean LokiBlobMetadataStore, it's not closed.`);

src/blob/persistence/SqlBlobMetadataStore.ts

@@ -103,6 +103,13 @@ export default class SqlBlobMetadataStore implements IBlobMetadataStore {
     connectionURI: string,
     sequelizeOptions?: SequelizeOptions
   ) {
+    // Enable encrypt connection for SQL Server
+    if (connectionURI.startsWith("mssql") && sequelizeOptions) {
+      sequelizeOptions.dialectOptions = sequelizeOptions.dialectOptions || {};
+      (sequelizeOptions.dialectOptions as any).options =
+        (sequelizeOptions.dialectOptions as any).options || {};
+      (sequelizeOptions.dialectOptions as any).options.encrypt = true;
+    }
     this.sequelize = new Sequelize(connectionURI, sequelizeOptions);
   }
 

src/common/persistence/SqlExtentMetadataStore.ts

@@ -36,6 +36,13 @@ export default class SqlExtentMetadataStore implements IExtentMetadataStore {
     connectionURI: string,
     sequelizeOptions?: SequelizeOptions
   ) {
+    // Enable encrypt connection for SQL Server
+    if (connectionURI.startsWith("mssql") && sequelizeOptions) {
+      sequelizeOptions.dialectOptions = sequelizeOptions.dialectOptions || {};
+      (sequelizeOptions.dialectOptions as any).options =
+        (sequelizeOptions.dialectOptions as any).options || {};
+      (sequelizeOptions.dialectOptions as any).options.encrypt = true;
+    }
     this.sequelize = new Sequelize(connectionURI, sequelizeOptions);
   }