Skip to content

Commit

Permalink
Fixes AB#1130: Title on learn more certificate deprecation link
Browse files Browse the repository at this point in the history
  • Loading branch information
gingi committed Jan 5, 2024
1 parent 9e1ae38 commit b8c9ba5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions desktop/i18n/resources.resjson
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"account-summary-card.url": "Url",
"activity-monitor-item.progressBar": "Item progress",
"add-certificate-form.certificate.deprecationWarning": "The Batch account certificates feature is deprecated and will be retired on February 29, 2024. Please transition to using Azure Key Vault to securely access and install certificates on your Batch pools.",
"add-certificate-form.certificate.deprecationWarningLinkTitle": "Documentation on certificate feature deprecation",
"add-certificate-form.certificate.description": "Select a certificate (pfx or cer) to upload",
"add-certificate-form.certificate.invalid": "Certificate need to be valid CER or PFX files only",
"add-certificate-form.certificate.label": "Certificate",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
<bl-banner class="certificate-deprecation-warning" type="warning">
<div message>
{{'add-certificate-form.certificate.deprecationWarning' | i18n }}
<a class="certificate-warning-alternative-link" (click)="openLink('https://learn.microsoft.com/azure/batch/batch-certificate-migration-guide')" href="javascript:void(0)">{{'common.learnMore' | i18n}}</a>
<a class="certificate-warning-alternative-link"
(click)="openLink('https://learn.microsoft.com/azure/batch/batch-certificate-migration-guide')"
[title]="'add-certificate-form.certificate.deprecationWarningLinkTitle' | i18n"
href="javascript:void(0)">{{'common.learnMore' | i18n}}</a>
</div>
</bl-banner>
<p>{{ form.controls.certificate.value }}</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ add-certificate-form:
required: Please select a valid certificate file
invalid: Certificate need to be valid CER or PFX files only
deprecationWarning: The Batch account certificates feature is deprecated and will be retired on February 29, 2024. Please transition to using Azure Key Vault to securely access and install certificates on your Batch pools.
deprecationWarningLinkTitle: Documentation on certificate feature deprecation
password:
label: Certificate password
required: Password is required if the certificate format is '.pfx'

0 comments on commit b8c9ba5

Please sign in to comment.