Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: memory leak in test? automatically unsubscribe from all subscribe #1078

Merged
merged 5 commits into from
Feb 21, 2018

Conversation

timotheeguerin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #1078 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
- Coverage   53.64%   53.55%   -0.09%     
==========================================
  Files         859      859              
  Lines       20241    20241              
  Branches     2277     2277              
==========================================
- Hits        10858    10841      -17     
- Misses       9383     9400      +17
Impacted Files Coverage Δ
...ob/action/add/job-create-basic-dialog.component.ts 68.42% <0%> (-15.79%) ⬇️
app/services/core/data/list-view.ts 84.55% <0%> (-3.26%) ⬇️
app/services/core/data/generic-view.ts 91.66% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f0df6...8aa5f8e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit f966e93 into master Feb 21, 2018
@timotheeguerin timotheeguerin deleted the fix/test-mem branch February 21, 2018 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant