Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create button for storage container under data menu is broken #2579

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

wanghoppe
Copy link
Member

@wanghoppe wanghoppe commented Oct 13, 2022

Fix: AB#1011,
To repro can see AB#609

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #2579 (f310925) into master (ab5bf75) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f310925 differs from pull request most recent head 18e4044. Consider uploading reports for the commit 18e4044 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
- Coverage   64.99%   64.99%   -0.01%     
==========================================
  Files         915      915              
  Lines       26371    26368       -3     
  Branches     5193     5192       -1     
==========================================
- Hits        17139    17137       -2     
+ Misses       9232     9231       -1     
Impacted Files Coverage Δ
...-flask/ui/buttons/clickable/clickable.component.ts 97.91% <ø> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5bf75...18e4044. Read the comment docs.

@wanghoppe
Copy link
Member Author

wanghoppe commented Oct 24, 2022

Using <bl-button> and matMenuTriggerFor directive together has the problem and deleting those codes in PR fixes it. It seems that the add button in the data Menu is the only use case, so hopefully it won't break others

@wanghoppe wanghoppe merged commit 47c2a35 into master Oct 25, 2022
@wanghoppe wanghoppe deleted the hoppe/fix-menu branch October 25, 2022 03:28
@cRui861
Copy link
Member

cRui861 commented Feb 1, 2023

Fixed #2636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants