-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: announce ‘no match’ information on subscription filter #2584
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2584 +/- ##
==========================================
- Coverage 64.99% 64.99% -0.01%
==========================================
Files 915 915
Lines 26368 26379 +11
Branches 5192 5197 +5
==========================================
+ Hits 17137 17144 +7
- Misses 9231 9235 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Great use of the LiveAnnouncer
utility. Only suggestion is to localize the strings being announced.
@gingi I made some changes to the unit test to pass the CI check, you might need to approve it again. |
Fixed #2634 |
fix: AB#758