Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility bug fixes #2629

Merged
merged 9 commits into from
Jan 27, 2023
Merged

Accessibility bug fixes #2629

merged 9 commits into from
Jan 27, 2023

Conversation

gingi
Copy link
Member

@gingi gingi commented Jan 25, 2023

Several other improvements:

  • Systemic application of red asterisks for required fields (input directive only set it as a read-only property that did not honor validations or explicit required HTML attributes)
  • Localization of several components
  • Replacement of some custom colors with theme colors
  • Corrected internal spelling of several classes, files, and directories

Most visible change is the removal of the light gray background of the square icon buttons.

Old:
MicrosoftTeams-image (2)

New:
image

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #2629 (5cef89a) into master (ee1f66d) will increase coverage by 0.01%.
The diff coverage is 76.74%.

❗ Current head 5cef89a differs from pull request most recent head 87c2a34. Consider uploading reports for the commit 87c2a34 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2629      +/-   ##
==========================================
+ Coverage   65.08%   65.09%   +0.01%     
==========================================
  Files         916      916              
  Lines       26420    26454      +34     
  Branches     5214     5230      +16     
==========================================
+ Hits        17195    17221      +26     
- Misses       9225     9233       +8     
Impacted Files Coverage Δ
src/@batch-flask/ui/dropdown/dropdown.module.ts 100.00% <ø> (ø)
...batch-flask/ui/server-error/server-error.module.ts 100.00% <ø> (ø)
src/@batch-flask/ui/sidebar/sidebar.module.ts 100.00% <ø> (ø)
.../app/components/account/action/account-commands.ts 34.21% <0.00%> (ø)
...ing-started-card/getting-started-card.component.ts 23.07% <0.00%> (ø)
...-picker/aad-app-picker/aad-app-picker.component.ts 16.66% <ø> (ø)
...p-secret-picker/aad-app-secret-picker.component.ts 21.87% <ø> (ø)
...entials-picker/aad-credentials-picker.component.ts 19.14% <ø> (ø)
...create-new-aad-app/create-new-aad-app.component.ts 19.29% <ø> (ø)
...ad-app-secret/generate-aad-app-secret.component.ts 31.25% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1f66d...87c2a34. Read the comment docs.

@gingi gingi force-pushed the shpaster/a11y-bugs branch 4 times, most recently from 74e4448 to a15b970 Compare January 26, 2023 20:38
@gingi gingi enabled auto-merge (rebase) January 26, 2023 22:51
@gingi gingi disabled auto-merge January 27, 2023 17:47
@gingi gingi merged commit 4cc837e into master Jan 27, 2023
@gingi gingi deleted the shpaster/a11y-bugs branch January 27, 2023 18:20
@cRui861
Copy link
Member

cRui861 commented Feb 1, 2023

Fixes #2634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants