Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-ms-command-name header support #2694

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

dpwatrous
Copy link
Member

This can be used to add a friendly name to HTTP requests such as "CreateAccount" or "ScalePool" for debugging/logging purposes.

This can be used to add a friendly name to HTTP requests such as "CreateAccount" or "ScalePool" for debugging/logging purposes.
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #2694 (547e545) into main (1154a4e) will increase coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 547e545 differs from pull request most recent head da8fa43. Consider uploading reports for the commit da8fa43 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files        1200     1200           
  Lines       33367    33375    +8     
  Branches     6136     6140    +4     
=======================================
+ Hits        22084    22090    +6     
- Misses      11153    11154    +1     
- Partials      130      131    +1     
Impacted Files Coverage Δ
packages/common/src/ui-common/http/http-client.ts 93.93% <ø> (ø)
...ges/common/src/ui-common/http/fetch-http-client.ts 67.64% <66.66%> (-0.22%) ⬇️
packages/common/src/ui-common/http/constants.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1154a4e...da8fa43. Read the comment docs.

@dpwatrous dpwatrous enabled auto-merge (squash) March 24, 2023 04:01
@dpwatrous dpwatrous merged commit 3d905c9 into main Mar 24, 2023
@dpwatrous dpwatrous deleted the dpwatrous/httpclient-command-name branch March 24, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants