-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility bug fixes (865, 950, 990, 702, 671) #2704
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
- Coverage 65.08% 65.08% -0.01%
==========================================
Files 916 916
Lines 26477 26478 +1
Branches 5237 5237
==========================================
Hits 17233 17233
- Misses 9244 9245 +1
Continue to review full report in Codecov by Sentry.
|
<bl-button type="plain" icon="fa fa-plus spin-hover" color="light" title="Add a file group" [matMenuTriggerFor]="addFileGroupMenu" | ||
[disabled]="!hasAutoStorage" [@.disabled]="true"> | ||
(click)="addFileGroup()" (do)="addFileGroup()" [disabled]="!hasAutoStorage" [@.disabled]="true"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bl-button
doesn't play nicely with the mat-menu
component out of the box when used a trigger as I couldn't activate the trigger using the keyboard (at least on macOS). Mouse clicks seem fine.
mat-menu
expects an actual button
component to be used as a trigger, but here bl-button
is a div
not a button
element. I had to add click
and do
above in order to call trigger.openMenu()
programmatically.
...when tab order reaches table for the first time without interacting with the table using the arrow keys
c3ac7d8
to
35e32da
Compare
Fixes #2713 |
Resolves:
Notable changes:
keydown
events handled by theselect
component no longer propagatesmat-radio-button