Integrate localized strings into web and desktop app #2730

skapur12 · 2023-05-09T22:58:58Z

Add localization support to web package
Add a 'Merge Translations' node script to merge the shared libraries with web and desktop-specific translations and place them in web and desktop folders, respectively. It runs on every build
Switch Electron app to use new localized strings
Rename StandardLocalizer to BrowserLocalizer, and add error handling to BrowserLocalizer to fetch the appropriate file based on the locale in the user's browser
Add global build-translations command to package.json
Update README with instructions on setting up localization environment on dev box

codecov · 2023-05-10T07:15:12Z

Codecov Report

Merging #2730 (8b77e9c) into main (5621efd) will increase coverage by 0.00%.
The diff coverage is 75.92%.

❗ Current head 8b77e9c differs from pull request most recent head cc8f35d. Consider uploading reports for the commit cc8f35d to get more accurate results

@@           Coverage Diff           @@
##             main    #2730   +/-   ##
=======================================
  Coverage   66.41%   66.42%           
=======================================
  Files        1200     1201    +1     
  Lines       33430    33463   +33     
  Branches     6153     6161    +8     
=======================================
+ Hits        22202    22227   +25     
- Misses      11092    11101    +9     
+ Partials      136      135    -1

Files Changed	Coverage Δ
...eact/src/ui-react/account/create-account-action.ts	`92.72% <ø> (ø)`
...react/src/ui-react/components/form/action-form.tsx	`72.91% <ø> (ø)`
...ommon/src/ui-common/localization/http-localizer.ts	`68.96% <68.96%> (ø)`
...ommon/src/ui-common/localization/fake-localizer.ts	`73.33% <73.33%> (ø)`
...re/i18n/client-translations-loader.service.spec.ts	`100.00% <100.00%> (ø)`
...nt/core/i18n/client-translations-loader.service.ts	`85.71% <100.00%> (-0.40%)`	⬇️
...mmon/src/ui-common/environment/mock-environment.ts	`96.55% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5621efd...cc8f35d. Read the comment docs.

.gitignore

Localize/copy-translations.ps1

docs/build-localization-locally.md

package.json

packages/common/src/ui-common/localization/browser-localizer.ts

packages/react/src/ui-react/account/create-account-action.ts

util/bux/translation-functions.ts

packages/react/src/ui-react/account/__tests__/create-account-action.spec.tsx

desktop/src/app/app.component.ts

desktop/src/app/localizer/desktop-localizer.ts

desktop/src/client/main.ts

packages/common/src/ui-common/localization/http-localizer.ts

.gitignore

util/bux/package.json

web/package.json

packages/common/src/ui-common/__tests__/setup-tests.ts

packages/common/src/ui-common/__tests__/http-localizer.spec.ts

dpwatrous

The changes look good to me. I'm just going to block this until we've got a portal PR ready since it contains breaking changes.

* Added fake localizer * Switch desktop app to use new translations * Add script to combine translated files by language * Add global build-translations command * Update comments and docs accordingly with changes * Run merge-translations script on Azure DevOps path * Add localization for Batch Explorer web version * Generate translations for Create Account buttons * Add basic i18n support for web package * Rename StandardLocalizer to BrowserLocalizer * Add merge translations script for web and desktop * Remove powershell merge translations script * Add localization support for desktop app * Copy translations to web too and not just desktop * Add translations for playground buttons * Gitignore generated localization files * Update localization docs with setup instructions * Add package translations to mergeTranslations * Optimize package file creation and fix unit test * Update Electron app localization unit tests * Address all feedback on PR * Fix desktop localizer, translation function, tests * Fix Prettier issue with account yml file * Update client translations unit test accordingly * Add http-localizer unit test and minor fixes * Remove CustomGlobal and simplify navigator object * Add getLocale function to each localizer --------- Co-authored-by: David Watrous <509299+dpwatrous@users.noreply.github.com>

skapur12 requested review from cRui861, dpwatrous, gingi, zfengms, paterasMSFT, seth-barshay, wiboris and NickKouds as code owners May 9, 2023 22:58

skapur12 force-pushed the dpwatrous/fake-localizer branch 2 times, most recently from d12b0e8 to 0a964cd Compare May 9, 2023 23:27

skapur12 force-pushed the dpwatrous/fake-localizer branch 2 times, most recently from ce5b397 to dbdd483 Compare May 17, 2023 18:38

skapur12 force-pushed the dpwatrous/fake-localizer branch 2 times, most recently from b916476 to e292e0d Compare May 23, 2023 17:49

skapur12 force-pushed the dpwatrous/fake-localizer branch 3 times, most recently from 30b4245 to fbb8786 Compare June 4, 2023 22:45

dpwatrous requested changes Jun 7, 2023

View reviewed changes

skapur12 requested a review from wanghoppe as a code owner June 20, 2023 11:32

skapur12 force-pushed the dpwatrous/fake-localizer branch from 8044495 to c40c07b Compare June 20, 2023 16:55

dpwatrous reviewed Jun 23, 2023

View reviewed changes

desktop/src/app/app.component.ts Outdated Show resolved Hide resolved

dpwatrous reviewed Jun 23, 2023

View reviewed changes

desktop/src/app/localizer/desktop-localizer.ts Outdated Show resolved Hide resolved

skapur12 force-pushed the dpwatrous/fake-localizer branch from 9ebe7ca to 23cfc1e Compare June 30, 2023 13:31

skapur12 force-pushed the dpwatrous/fake-localizer branch from 23cfc1e to c8823c8 Compare July 17, 2023 06:26

gingi approved these changes Jul 19, 2023

View reviewed changes

dpwatrous reviewed Jul 20, 2023

View reviewed changes

dpwatrous reviewed Jul 27, 2023

View reviewed changes

packages/common/src/ui-common/__tests__/setup-tests.ts Outdated Show resolved Hide resolved

packages/common/src/ui-common/__tests__/http-localizer.spec.ts Outdated Show resolved Hide resolved

dpwatrous self-requested a review July 31, 2023 20:20

dpwatrous requested changes Jul 31, 2023

View reviewed changes

skapur12 added 24 commits July 31, 2023 13:35

Add global build-translations command

8bff893

Update comments and docs accordingly with changes

ac32380

Run merge-translations script on Azure DevOps path

7da21d9

Add localization for Batch Explorer web version

4609a68

Generate translations for Create Account buttons

9935ea7

Add basic i18n support for web package

5488d42

Rename StandardLocalizer to BrowserLocalizer

af4d629

Add merge translations script for web and desktop

cb3f6e1

Remove powershell merge translations script

07b7e09

Add localization support for desktop app

dbf75a1

Copy translations to web too and not just desktop

8af9a55

Add translations for playground buttons

20920ca

Gitignore generated localization files

2ca588d

Update localization docs with setup instructions

71a169c

Add package translations to mergeTranslations

2abf553

Optimize package file creation and fix unit test

33848fd

Update Electron app localization unit tests

fe969ad

Address all feedback on PR

9530375

Fix desktop localizer, translation function, tests

eb1eb82

Fix Prettier issue with account yml file

47e9245

Update client translations unit test accordingly

92134c0

Add http-localizer unit test and minor fixes

7972190

Remove CustomGlobal and simplify navigator object

0307daa

Add getLocale function to each localizer

cc8f35d

skapur12 force-pushed the dpwatrous/fake-localizer branch from 265821e to cc8f35d Compare July 31, 2023 20:35

dpwatrous self-requested a review August 1, 2023 13:01

dpwatrous approved these changes Aug 1, 2023

View reviewed changes

skapur12 merged commit 1aecc3b into main Aug 1, 2023
6 checks passed

skapur12 deleted the dpwatrous/fake-localizer branch August 1, 2023 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate localized strings into web and desktop app #2730

Integrate localized strings into web and desktop app #2730

skapur12 commented May 9, 2023 •

edited

Loading

codecov bot commented May 10, 2023 •

edited

Loading

dpwatrous left a comment

Integrate localized strings into web and desktop app #2730

Integrate localized strings into web and desktop app #2730

Conversation

skapur12 commented May 9, 2023 • edited Loading

codecov bot commented May 10, 2023 • edited Loading

Codecov Report

dpwatrous left a comment

Choose a reason for hiding this comment

skapur12 commented May 9, 2023 •

edited

Loading

codecov bot commented May 10, 2023 •

edited

Loading