Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indonesian translations and fix Portuguese locale code in desktop app #2776

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

skapur12
Copy link
Member

@skapur12 skapur12 commented Aug 8, 2023

  • Fix the locale code for Portuguese in the desktop app so that the Portuguese translations render correctly
  • Add Indonesian to list of supported languages in the desktop app
    • Checked multiple translation services and Edge/Google Chrome language settings, and it seems that the standard way to write the word ‘Indonesian’ in the Indonesian language for digital localization purposes is simply ‘Indonesia’
  • Disable security warning for non-English characters for locale file

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2776 (325a60a) into main (f31b8b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 325a60a differs from pull request most recent head ac11821. Consider uploading reports for the commit ac11821 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2776   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files        1209     1209           
  Lines       33750    33751    +1     
  Branches     6218     6219    +1     
=======================================
+ Hits        22485    22486    +1     
  Misses      11126    11126           
  Partials      139      139           
Files Changed Coverage Δ
...sktop/src/@batch-flask/core/i18n/locale.service.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31b8b6...ac11821. Read the comment docs.

@skapur12 skapur12 merged commit f7ce356 into main Aug 8, 2023
6 checks passed
@skapur12 skapur12 deleted the bugfix/desktop-locales branch August 8, 2023 16:32
@cRui861
Copy link
Member

cRui861 commented Nov 8, 2023

Fixes #2838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants