Add type safety to shared libraries localization #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skapur12
requested review from
cRui861,
dpwatrous,
gingi,
zfengms,
wiboris,
NickKouds and
wanghoppe
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2777 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 1209 1209
Lines 33751 33751
Branches 6218 6169 -49
=======================================
Hits 22486 22486
Misses 11126 11126
Partials 139 139
Continue to review full report in Codecov by Sentry.
|
dpwatrous
requested changes
Aug 11, 2023
skapur12
force-pushed
the
feature/loc-type-safety
branch
from
a231704
to
7dbfb09
Compare
dpwatrous
requested changes
Aug 17, 2023
skapur12
force-pushed
the
feature/loc-type-safety
branch
from
7dbfb09
to
3e770b5
Compare
dpwatrous
approved these changes
Aug 18, 2023
gingi
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Add type safety to shared libraries localization * Fix localization unit test * Switch folder order of generated and localization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type safety to localization interface
build-translationsto generate Typescript interface for each package containing all strings for that packagebuild-translationsnow happens before Typescript compilationclean:localizationcommand to clean out the generated Typescript files(Note: I checked that these changes work with the portal by bux linking them and no changes need to be made to the portal- as we didn't change the localizer interface here and only the translate function, which isn't called yet in the portal ReactViews)