-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: load more and virtual scrolling #2799
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2799 +/- ##
==========================================
- Coverage 66.54% 66.51% -0.04%
==========================================
Files 1240 1245 +5
Lines 33961 34115 +154
Branches 6149 6219 +70
==========================================
+ Hits 22600 22692 +92
- Misses 11226 11286 +60
- Partials 135 137 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good - I love the tests and demos you added. Let's follow up tomorrow and talk more about the overall design.
Random thought: this seems like a really good use case for some automated performance tests. I'd love to be able to track the performance of the data grid in various scenarios over time. We already have a few tests in Playwright which run a real Electron process. Seems like that might be a good place to put perf tests.
packages/playground/src/demo/display/task-grid/task-data-grid.tsx
Outdated
Show resolved
Hide resolved
packages/playground/src/demo/display/task-grid/task-data-grid.tsx
Outdated
Show resolved
Hide resolved
0f076b4
to
17c0c1e
Compare
1ce6bf8
to
5819fab
Compare
5819fab
to
00b4c38
Compare
No description provided.