Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataplane update #2803

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Dataplane update #2803

merged 5 commits into from
Oct 13, 2023

Conversation

cRui861
Copy link
Member

@cRui861 cRui861 commented Sep 16, 2023

Update properties for models. Also added type definitions for JSON for issues with only an object type

@cRui861 cRui861 marked this pull request as ready for review October 13, 2023 20:43
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2803 (82a23fe) into main (e04d7a6) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 82a23fe differs from pull request most recent head 94de109. Consider uploading reports for the commit 94de109 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
+ Coverage   66.49%   66.54%   +0.05%     
==========================================
  Files        1232     1240       +8     
  Lines       33888    33942      +54     
  Branches     6173     6191      +18     
==========================================
+ Hits        22534    22588      +54     
  Misses      11219    11219              
  Partials      135      135              
Files Coverage Δ
desktop/src/app/models/azure-batch/job/job.ts 95.83% <100.00%> (+0.18%) ⬆️
desktop/src/app/models/azure-batch/node/node.ts 96.07% <100.00%> (+0.07%) ⬆️
desktop/src/app/models/azure-batch/pool/pool.ts 90.47% <100.00%> (+0.47%) ⬆️
desktop/src/app/models/batch-pool-identity.ts 100.00% <100.00%> (ø)
.../src/app/models/compute-node-identity-reference.ts 100.00% <100.00%> (ø)
desktop/src/app/models/container-setup.ts 100.00% <100.00%> (ø)
...ktop/src/app/models/dtos/container-registry.dto.ts 100.00% <ø> (ø)
desktop/src/app/models/http-header.ts 100.00% <100.00%> (ø)
desktop/src/app/models/image-reference.ts 100.00% <100.00%> (ø)
desktop/src/app/models/network-configuration.ts 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04d7a6...94de109. Read the comment docs.

@cRui861 cRui861 merged commit e259c01 into main Oct 13, 2023
6 checks passed
@cRui861 cRui861 deleted the rechen/dataplane-api-update branch October 13, 2023 23:29
@cRui861
Copy link
Member Author

cRui861 commented Nov 8, 2023

Fixes #2834

gingi pushed a commit that referenced this pull request Nov 9, 2023
* WIP updating models to include new properties after data plane version update

* Finish adding properties for dataplane api update

* Small fix

* Update VMExtension model and add in type definition for JSON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants