Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to gallery and to storage functionality #2824

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

gingi
Copy link
Member

@gingi gingi commented Oct 27, 2023

  • Various issues with controls that were not rendered correctly in Gallery views
  • Updates Python backend to MSAL

Fixes #2785

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2824 (73a8720) into main (8de3de2) will increase coverage by 0.15%.
The diff coverage is 51.16%.

❗ Current head 73a8720 differs from pull request most recent head 9b886ce. Consider uploading reports for the commit 9b886ce to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2824      +/-   ##
==========================================
+ Coverage   66.56%   66.72%   +0.15%     
==========================================
  Files        1245     1245              
  Lines       34122    34129       +7     
  Branches     6220     6222       +2     
==========================================
+ Hits        22714    22773      +59     
+ Misses      11272    11220      -52     
  Partials      136      136              
Files Coverage Δ
...re/data/targeted-data-cache/targeted-data-cache.ts 81.81% <100.00%> (ø)
desktop/src/@batch-flask/core/record/decorators.ts 91.42% <100.00%> (+0.51%) ⬆️
...ubmit/parameter-input/parameter-input.component.ts 100.00% <100.00%> (ø)
desktop/src/app/models/blob-container.ts 60.00% <100.00%> (ø)
.../src/app/services/core/data/storage-list-getter.ts 23.80% <ø> (+23.80%) ⬆️
...op/src/app/services/storage/models/storage-blob.ts 100.00% <100.00%> (ø)
...src/app/services/storage/storage-client.service.ts 40.00% <ø> (+20.00%) ⬆️
...ponents/gallery/submit/market-application.model.ts 92.98% <80.00%> (-1.47%) ⬇️
...ts/gallery/submit/submit-ncj-template.component.ts 67.76% <0.00%> (ø)
.../src/app/services/python-rpc/python-rpc.service.ts 11.11% <0.00%> (+6.43%) ⬆️
... and 4 more

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de3de2...9b886ce. Read the comment docs.

Also supports a custom name on the `@Model()` decorator.
Bug introduced in #2745: No handler for a file group that has changed. Also restores the picker option labels.

Backfills container names on certain API calls because they are not returned, but are needed by various UI flows.
desktop/python/server/aad_auth.py Outdated Show resolved Hide resolved
desktop/python/server/aad_auth.py Outdated Show resolved Hide resolved
@gingi gingi merged commit f6ad839 into main Nov 1, 2023
6 checks passed
@gingi gingi deleted the shpaster/storage-blob-fix branch November 1, 2023 21:54
@cRui861
Copy link
Member

cRui861 commented Nov 8, 2023

Fixes #2836

@cRui861
Copy link
Member

cRui861 commented Nov 8, 2023

Fixes #2837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'adalauthentication' object has no attribute 'get_token'
3 participants